refactor(enginenetx): group by domain's endpoint #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no point in using "www.example.com" as the key with policies for mixed ports when actually we should be using "www.example.com:443" such that we only group policies for the same port. This needs to happen both for the data format of the stats stored to disk and for the user-provided static policy format. Part of ooni/probe#2531
bassosimone
commented
Sep 26, 2023
bassosimone
changed the title
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
There's no point in grouping tactics by "www.example.com" for stats stored on disk and user-provided static policies. By grouping by domain alone, we'll end up with mixed tactics for different ports all being together. Which means that, code that needs to filter, needs to explicitly filter by port. If we used "www.example.com:443" as the group-by key, conversely, we would not need to write specialized filtering code to only get data for the correct port. So, let's do that and let's simplify future code that will need to get tactics known for work for a given domain _and_ port. Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no point in grouping tactics by "www.example.com" for stats stored on disk and user-provided static policies. By grouping by domain alone, we'll end up with mixed tactics for different ports all being together. Which means that, code that needs to filter, needs to explicitly filter by port. If we used "www.example.com:443" as the group-by key, conversely, we would not need to write specialized filtering code to only get data for the correct port. So, let's do that and let's simplify future code that will need to get tactics known for work for a given domain and port.
Part of ooni/probe#2531