feat(enginenetx): add policy based on stats #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This policy first checks the stats and sorts the entries for which
we have the highest success rate. Then, we use an underlying policy
to produce suitable tactics for the HTTPS dialer.
While there, rename statstracker{,_test}.go to statsmanager{,_test}.go
because the type inside it is called "state manager". The state
tracker is an abstract concept only used by the https dialer code.
Part of ooni/probe#2531
bassosimone
commented
Sep 26, 2023
bassosimone
commented
Sep 26, 2023
Conflicts: internal/enginenetx/statspolicy.go
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This policy first checks the stats and sorts the entries for which we
have the highest nonzero success rate. Then, we use an underlying policy
to produce additional suitable tactics for the HTTPS dialer.
There is a check preventing the same tactic from being emitted twice.
This means that, if we emit a tactic looking into the stats, we're not
going to emit the same exact tactic again when using our beacons policy
generator.
Also, because we try using stable sorting, and assuming some tactics
work, we would most likely continue using the tactics that work, until
something bad happens and we need to try and see whether other tactics
work.
While there, rename statstracker{,_test}.go to statsmanager{,_test}.go
because the type inside it is called "state manager". The state tracker
is an abstract concept only used by the https dialer code.
Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This policy first checks the stats and sorts the entries for which we have the highest nonzero success rate. Then, we use an underlying policy to produce additional suitable tactics for the HTTPS dialer.
There is a check preventing the same tactic from being emitted twice. This means that, if we emit a tactic looking into the stats, we're not going to emit the same exact tactic again when using our beacons policy generator.
Also, because we try using stable sorting, and assuming some tactics work, we would most likely continue using the tactics that work, until something bad happens and we need to try and see whether other tactics work.
While there, rename statstracker{,_test}.go to statsmanager{,_test}.go because the type inside it is called "state manager". The state tracker is an abstract concept only used by the https dialer code.
Part of ooni/probe#2531