Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(enginenetx): gracefully handle more nil cases #1316

Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix(enginenetx): gracefully handle more nil cases #1316

merged 2 commits into from
Sep 27, 2023

Conversation

bassosimone
Copy link
Contributor

This diff adjusts code inside the enginenetx package such that we gracefully deal with nil values in more cases.

Part of ooni/probe#2531

@bassosimone
fix(enginenetx): gracefully handle more nil cases
d2dd1ca 
This diff adjusts code inside the enginenetx package such that we
gracefully deal with nil values in more cases.

Part of ooni/probe#2531
@bassosimone bassosimone merged commit 58a4845 into master Sep 27, 2023
8 checks passed
@bassosimone bassosimone deleted the issue/2531 branch September 27, 2023 08:20
@bassosimone bassosimone mentioned this pull request Oct 2, 2023
Closed
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this pull request Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(enginenetx): gracefully handle more nil cases (ooni#1316)
546d6f4 
This diff adjusts code inside the enginenetx package such that we
gracefully deal with nil values in more cases.

Part of ooni/probe#2531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bassosimone