refactor(mlablocate): use interface, remove unused fields, add docs #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very light refactoring of the mlablocate package where we do the following things: 1. use interfaces rather depending on other pkgs where possible 2. only keep the fields we really need in the result struct 3. write more comprehensive docs (including todo-next comments) While there, use `neubot/dash` rather than `ndt7` for the tests.
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
…oni#383) This is a very light refactoring of the mlablocate package where we do the following things: 1. use interfaces rather depending on other pkgs where possible 2. only keep the fields we really need in the result struct 3. write more comprehensive docs (including todo-next comments) While there, use `neubot/dash` rather than `ndt7` for the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very light refactoring of the mlablocate package where we do
the following things:
use interfaces rather depending on other pkgs where possible
only keep the fields we really need in the result struct
write more comprehensive docs (including todo-next comments)
While there, use
neubot/dashrather thanndt7for the tests.