Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mlablocatev2): use interfaces, add missing tests, add docs #384

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

bassosimone
Copy link
Contributor

This is a very light refactoring of the mlablocatev2 package where we do
the following things:

  1. use interfaces rather than depending on other pkgs where possible

  2. add a missing test to the test suite

  3. write more comprehensive docs (including todo-next comments)

This is a very light refactoring of the mlablocatev2 package where we do
the following things:

1. use interfaces rather than depending on other pkgs where possible

2. add a missing test to the test suite

3. write more comprehensive docs (including todo-next comments)
@bassosimone bassosimone changed the title refactor(mlablocatev2): use interfaces, remove unused fields, add docs refactor(mlablocatev2): use interfaces, add missing tests, add docs Jun 15, 2021
@bassosimone bassosimone merged commit d84cf5b into master Jun 15, 2021
@bassosimone bassosimone deleted the develop branch June 15, 2021 17:25
ainghazal pushed a commit to ainghazal/probe-cli that referenced this pull request Mar 8, 2022
…oni#384)

This is a very light refactoring of the mlablocatev2 package where we do
the following things:

1. use interfaces rather than depending on other pkgs where possible

2. add a missing test to the test suite

3. write more comprehensive docs (including todo-next comments)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant