fix context timeout not working as intended bug #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff fixes the context timeout not working as intended bug described in #994. Before canceling the context we need to increase the counter so that we're sure that canceling the context happens _after_ we increased the counter. Otherwise, it may actually happen before depending on the choices made by the Go scheduler. Closes #994. If I am wrong we will reopen, but I think this is at least a good explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff fixes the context timeout not working as intended bug
described in #994.
Before canceling the context we need to increase the counter so that
we're sure that canceling the context happens after we increased
the counter. Otherwise, it may actually happen before depending on the
choices made by the Go scheduler.
Closes #994. If I am
wrong we will reopen, but I think this is at least a good explanation.