Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update well know OONI hosts we use #117

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Update well know OONI hosts we use #117

merged 3 commits into from
Nov 27, 2019

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Nov 22, 2019

  1. make sure we use the canonical {bouncer,orchestrate}.ooni.io for
    bouncer and for orchestra (it was already the case):
orchestra/testlists/testlists.go:       DefaultBaseURL = "https://orchestrate.ooni.io"
session/session.go:                     Address: "https://bouncer.ooni.io",
  1. make sure we use ps-test.ooni.io for everything test related:
bouncer/bouncer_test.go:                BaseURL:    "https://ps-test.ooni.io/",
collector/collector_test.go:            BaseURL:    "https://ps-test.ooni.io/",
session/session_test.go:        sess.AddAvailableHTTPSBouncer("https://ps-test.ooni.io")
session/session_test.go:        sess.AddAvailableHTTPSCollector("https://ps-test.ooni.io")
session_test.go:        sess.AddAvailableHTTPSBouncer("https://ps-test.ooni.io")
session_test.go:        sess.AddAvailableHTTPSCollector("https://ps-test.ooni.io")

Prompted by measurement-kit/measurement-kit#1896

1. make sure we use the canonical `{bouncer,orchestrate}.ooni.io` for
bouncer and for orchestra (it was already the case):

```
orchestra/testlists/testlists.go: DefaultBaseURL = "https://orchestrate.ooni.io"
session/session.go: Address: "https://bouncer.ooni.io",
```

2. make sure we use `ps-test.ooni.io` for everything test related:

```
bouncer/bouncer_test.go: BaseURL:    "https://ps-test.ooni.io/",
collector/collector_test.go: BaseURL:    "https://ps-test.ooni.io/",
session/session_test.go: sess.AddAvailableHTTPSBouncer("https://ps-test.ooni.io")
session/session_test.go: sess.AddAvailableHTTPSCollector("https://ps-test.ooni.io")
```

Prompted by measurement-kit/measurement-kit#1896
@bassosimone bassosimone added the chore routine tasks that must be done, but require little active brain power label Nov 22, 2019
@bassosimone bassosimone self-assigned this Nov 22, 2019
@hellais hellais added effort/XS Extra small effort priority/high High priority labels Nov 22, 2019
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@bassosimone bassosimone merged commit dbfa248 into master Nov 27, 2019
@bassosimone bassosimone deleted the feature/oonihosts branch November 27, 2019 09:30
@hellais hellais added this to the Sprint 1 - Parrotfish milestone Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore routine tasks that must be done, but require little active brain power effort/XS Extra small effort priority/high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants