quic: readfrom/writeto saver, updated tests #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
reviewed
Jan 12, 2021
netx/archival/archival.go
Outdated
| @@ -492,6 +492,7 @@ func NewNetworkEventsList(begin time.Time, events []trace.Event) []NetworkEvent | |||
| } | |||
| if ev.Name == errorx.ReadOperation { | |||
There was a problem hiding this comment.
I think here you should handle also ReadFromOperation?
netx/archival/archival.go
Outdated
| @@ -501,6 +502,7 @@ func NewNetworkEventsList(begin time.Time, events []trace.Event) []NetworkEvent | |||
| } | |||
| if ev.Name == errorx.WriteOperation { | |||
There was a problem hiding this comment.
I think here you should also handle WriteToOperation?
netx/errorx/errorx.go
Outdated
| @@ -74,6 +74,12 @@ const ( | |||
| // WriteOperation is when we write to a socket | |||
| WriteOperation = "write" | |||
|
|
|||
| // ReadFromOperation is when we read from an UDP socket | |||
| ReadFromOperation = "readfrom" | |||
There was a problem hiding this comment.
We use _ to separate other operations, so please use read_from
netx/errorx/errorx.go
Outdated
| ReadFromOperation = "readfrom" | ||
|
|
||
| // WriteToOperation is when we write to an UDP socket | ||
| WriteToOperation = "writeto" |
netx/quicdialer/system_test.go
Outdated
| @@ -11,6 +11,44 @@ import ( | |||
| "github.com/ooni/probe-engine/netx/trace" | |||
| ) | |||
|
|
|||
| func TestSystemDialerSuccess(t *testing.T) { | |||
There was a problem hiding this comment.
This test seems redundant? Isn't this a subset of TestSystemDialerSuccessWithReadWrite?
netx/quicdialer/system_test.go
Outdated
| if err.Error() != "quicdialer: invalid IP representation" { | ||
| t.Fatal("expected another error here") | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.