Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notification settings screens #1090

Closed
lorenzoPrimi opened this issue Apr 9, 2020 · 1 comment · Fixed by ooni/probe-ios#346 or ooni/probe-android#310
Closed

Remove notification settings screens #1090

lorenzoPrimi opened this issue Apr 9, 2020 · 1 comment · Fixed by ooni/probe-ios#346 or ooni/probe-android#310
Assignees
Labels
ooni/probe-mobile issues related to OONI Probe mobile priority/medium

Comments

@lorenzoPrimi
Copy link

Some changes to do in the setting screen and preferences, they are all interconnected but they serve different purposes:

  • Remove local notification setting. This is just an overcomplication for the user and will be removed forever, both in the screen and preferences array.

  • Remove notification preference screen in fdroid bundle, remove it at all. So in that flavor there will be no notification menu item.

  • Comment push notification setting item in the full flavor. As notifications are not used in the moment the entry of this setting screen will be just commented in the master branch (and uncommented in the countly branch)

@lorenzoPrimi lorenzoPrimi added ooni/probe-mobile issues related to OONI Probe mobile priority/medium effort/M labels Apr 9, 2020
@lorenzoPrimi lorenzoPrimi added this to the Sprint 11 - Blue Bottles milestone Apr 9, 2020
@lorenzoPrimi lorenzoPrimi self-assigned this Apr 9, 2020
@hellais hellais changed the title Settings screen changes Remove notification settings screens Apr 14, 2020
@lorenzoPrimi
Copy link
Author

lorenzoPrimi commented Apr 15, 2020

ooni/probe-ios#346 and ooni/probe-android#310 have been opened.
When they will be approved I'd need to

  • Merge master into the countly and automated_testing branch
  • Re-add notification preference in the countlybranch
  • Fix the local notification in the automated_testing branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ooni/probe-mobile issues related to OONI Probe mobile priority/medium
Projects
None yet
1 participant