Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: stop bundling geoip databases into the probe #2085

Open
1 of 9 tasks
bassosimone opened this issue May 6, 2022 · 0 comments
Open
1 of 9 tasks

plan: stop bundling geoip databases into the probe #2085

bassosimone opened this issue May 6, 2022 · 0 comments
Assignees
Labels
cleanup There's need to cleanup stuff a bit data quality enhancement improving existing code or new feature ooni/probe-engine priority/medium techdebt This issue describes technical debt user feedback requests that have been added to the backlog as a direct result of user feedback or testing

Comments

@bassosimone
Copy link
Contributor

bassosimone commented May 6, 2022

This plan describes the required steps for stopping to bundle geoip databases into the probe. We previously discussed why this is problematic at #1954. A previous version of this plan can be found at #1954 (comment). This issue is an umbrella issue. The plan has been agreed upon with @hellais. Thanks to the users who prodded us to stop bundling geoip databases into the probe! <3

  • Add support for returning probe_asn and probe_ip as part of check-in api#276 is merged
  • when not using a proxy, the probe does not perform IP lookup and gets ASN and CC from the check-in API
  • when using a proxy, the probe performs an IP lookup and passes X-Real-IP to the check-in API, which, in turn, causes the check-in API to use X-Real-IP rather than the user's IP for performing the geolocation
  • we extend the web connectivity test helper to periodically fetch geoip databases
  • we extend the web connectivity test helper to map all the resolved IPs (by the TH or by the probe) to ASNs
  • we extend the websteps test helper to map all the resolved IPs (by the TH or by the probe) to ASNs
  • we define a GeoIP databases update procedure for the check-in API
  • we define a GeoIP databases update procedure for the test helper
  • we drop support for performing GeoIP lookups from the probe

The above high-level plan needs to be converted into issues that are more fine grained.

@bassosimone bassosimone added enhancement improving existing code or new feature priority/medium user feedback requests that have been added to the backlog as a direct result of user feedback or testing ooni/probe-engine techdebt This issue describes technical debt cleanup There's need to cleanup stuff a bit labels May 6, 2022
@bassosimone bassosimone self-assigned this May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup There's need to cleanup stuff a bit data quality enhancement improving existing code or new feature ooni/probe-engine priority/medium techdebt This issue describes technical debt user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Development

No branches or pull requests

1 participant