Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear how to get test methodology information #822

Closed
bassosimone opened this issue Mar 3, 2017 · 41 comments
Closed

Unclear how to get test methodology information #822

bassosimone opened this issue Mar 3, 2017 · 41 comments
Assignees
Labels
ooni/probe-mobile issues related to OONI Probe mobile ux

Comments

@bassosimone
Copy link
Contributor

User story: I am an advanced user, I end up in the Run Tests section where I am clearly hinted to hit the Run button to start tests, then I am hinted to go into the Past Tests section, where I can see results; at this point, I see anomalies that I think should not be anomalies, and I don't have a quick way to see the test methodology from the results (not to mention that it's not obvious to me that I can get info on a specific test by going on the Run Tests section and running it).

(IMHO this history seems to suggest that the place where one may want to know about the methodology is indeed when he/she is looking at results, no?)

xref: https://github.com/TheTorProject/ooniprobe-ios/issues/101

@lorenzoPrimi
Copy link

@bassosimone I guess this can be closed as it's refered to 1.x app

@bassosimone
Copy link
Contributor Author

It's not clear to me whether the new app makes this user story possible!

@lorenzoPrimi
Copy link

I don't really understand what you try to ask here.
When you finish run a test you go in the test result page, the new test is highlighted.
Then you see some basic information about the test like number of site tested/number blocked, or upload/download speed etc.

@bassosimone
Copy link
Contributor Author

Sorry for being brief. Then, the user request was to have a shortcut to the measurement methodology from the results, so to better evaluate whether it was false positive or not.

@lorenzoPrimi
Copy link

It's not in the mockup at the moment.
There will be a button to "re-test" an url in case of web censorship test.
I don't think it's needed any button for the other types of test, as they are only two taps away:

  • Tap Dashboard
  • Tap Run

@bassosimone
Copy link
Contributor Author

Okay, then let's close this issue.

@hellais
Copy link
Member

hellais commented Mar 26, 2018

Actually I think the new UX does have enough space to fit links to the methodology (on the test details screen) and we should be sure to take this into account when @agrabeli and @elioqoshi work on the copy.

I would say we keep this open and have it as a feature for the new app.

@hellais hellais reopened this Mar 26, 2018
@lorenzoPrimi
Copy link

@hellais I don't like having an "useless" button for an action that can be achieved only with two taps instead of one.
Discuss.

@hellais
Copy link
Member

hellais commented Mar 26, 2018

@lorenzoPrimi perhaps I didn't explain myself well. What I am suggesting is that we add to the following screen this button:

00testoverview websites methodology

I believe we don't have a link to the methodology anywhere else in the app.

@lorenzoPrimi
Copy link

@bassosimone is talking about adding a Run button inside test result of a specific test. It's a different thing

@hellais
Copy link
Member

hellais commented Mar 26, 2018

@bassosimone well that was his suggestion, but what I am saying is that to satisfy the user story of a user obtaining methodology information we should be sure to remember to add a link to the methodology in the test overview (which we currently don't have).

@elioqoshi
Copy link

Linking the Methodoloy in a Disclaimer style on that screen is fine for me. Let's keep this open until it's implemented.

@lorenzoPrimi
Copy link

Ok so it's not about the first request of sbs.
Actually we already have a link to the methodoloy in the current app...

@hellais
Copy link
Member

hellais commented Mar 26, 2018

@elioqoshi it's probably also worth considering if there is some place inside of the test results pages to add another link that points to the test description (the screen I linked above).

@lorenzoPrimi
Copy link

In current app:
screenshot_20180326-153729

@elioqoshi
Copy link

@hellais you mean in the Test Results Summary pages of specific measurements to link to their respective test description?

@hellais
Copy link
Member

hellais commented Mar 26, 2018

you mean in the Test Results Summary pages of specific measurements to link to their respective test description?

Correct.

@bassosimone
Copy link
Contributor Author

but what I am saying is that to satisfy the user story of a user obtaining methodology information we should be sure to remember to add a link to the methodology in the test overview

Actually that was I was suggesting. Too bad I was not able to explain myself well :-/

@lorenzoPrimi
Copy link

@elioqoshi @agrabeli will be a link to methodology in the description?

@hellais
Copy link
Member

hellais commented Oct 18, 2018

will be a link to methodology in the description?

Yes, let's not forget about adding links to the mockups and copy.

@lorenzoPrimi lorenzoPrimi transferred this issue from ooni/probe-android Jan 17, 2019
@lorenzoPrimi lorenzoPrimi added the ooni/probe-mobile issues related to OONI Probe mobile label Jan 17, 2019
@elioqoshi elioqoshi added the ux label Jan 17, 2019
@elioqoshi
Copy link

Sorry, I missed this. Let's aim for this to be in 2.1

Will prepare the UX component for this.

@lorenzoPrimi
Copy link

@elioqoshi ok for 2.1, let me know as soon there is UX

@elioqoshi
Copy link

@lorenzoPrimi thinking about this and that the methodology is not as critical for the majority of the users, I'd suggest to add this as another option in the Configure Test screen of that particular test

@lorenzoPrimi
Copy link

lorenzoPrimi commented Mar 4, 2019

@elioqoshi I don't think this is a configuration option, in the option screen there can be only configuration settings.
This it's a more in-depth information, so it belongs to test overview or to any informative screen

@elioqoshi
Copy link

Does not matter that much I'd say. Many apps have their licensing information in the Settings.

This it's a more in-depth information, so it belongs to test overview or to any informative screen

I don't agree with this logic but sure, we can do that.

@elioqoshi
Copy link

elioqoshi commented Mar 4, 2019

Let's use a medium emphasized button (outlined)
image

@lorenzoPrimi
Copy link

Does not matter that much I'd say. Many apps have their licensing information in the Settings.

I understand, like our About that is in the settings
So I guess it can be in both screens, depending on

  1. How much visible should be
  2. If we are using a string (to translate) or a link that will be opened in browser

From the screenshot for the (2) seems it's a link

@elioqoshi
Copy link

elioqoshi commented Mar 4, 2019

I understand, like our About that is in the settings

Exactly.

If we are using a string (to translate) or a link that will be opened in browser

I mean it will link to the website but the actual string will be needed and translated.

If we do it in the Configure screen, it would look something like this:

image

@elioqoshi
Copy link

elioqoshi commented Mar 4, 2019

Actually, this should be better:

image

There are good guidelines on how to design Settings in Android:
https://source.android.com/devices/tech/settings/settings-guidelines

@lorenzoPrimi
Copy link

First one is iOS style, second one is Android.
So this "setting" will open an external link, right?
@xanscale is this possible on Android?
No problem on iOS

@xanscale
Copy link

xanscale commented Mar 5, 2019

No problem on Android

@elioqoshi
Copy link

Yep, it will be an external link. Not sure about "More Information". Maybe "About Test"?

@lorenzoPrimi
Copy link

This is more a copy issue. @agrabeli

@elioqoshi
Copy link

@lorenzoPrimi Copy and UX are very closely related. These things need feedback from both parties.

@lorenzoPrimi
Copy link

@agrabeli and @elioqoshi let's define the copy needed for this so I can upload it with the next copy upload.

@lorenzoPrimi
Copy link

lorenzoPrimi commented Mar 24, 2019

"Settings.MoreInformation" = "More Information"
"Settings.Methodology.Title" = "Methodology"
"Settings.Methodology.Label" = "Methodology used for the {{TestName}} test"

@elioqoshi
Copy link

Looks good to me

@xanscale
Copy link

i can't use dynamic string there, so or we make a generic string like Methodology used for test or we make 4 string for each test suite

@agrabeli
Copy link
Member

The OONI Probe mobile app already links to the test methodologies (published on the OONI site). If you tap on each card, you will get a description where the name of each test (e.g. "Web Connectivity") links to its methodology description on the OONI site.

That said, since this was not obvious, it's probably good that a link to the Web Connectivity test description was added in the Websites Configuration page as well.

@bassosimone
Copy link
Contributor Author

So, it seems the current app (2.0.5/ios) is already good enough to satisfy the user story in the description of the tests. However, the user story was:

[...] I don't have a quick way to see the test methodology from the results

And I don't think it's satisfied in 2.0.5/ios.

@agrabeli
Copy link
Member

Perhaps we can add a sentence saying "Learn how this test works" which links to the test methodology page, right under the results (e.g. "htttps://ooni.io is accessible") in the individual measurement pages. In the case of NDT and DASH measurement pages, we can add this sentence right under the stats. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ooni/probe-mobile issues related to OONI Probe mobile ux
Projects
None yet
Development

No branches or pull requests

7 participants