Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: increase code coverage to >= 50% #948

Closed
bassosimone opened this issue Dec 28, 2019 · 3 comments
Closed

cli: increase code coverage to >= 50% #948

bassosimone opened this issue Dec 28, 2019 · 3 comments

Comments

@bassosimone
Copy link
Contributor

The code coverage used to be ~25% and has dropped to ~4% after 6cccfeb (part of ooni/probe-cli#88). We should understand why is that and we should also write more unit tests.

The >= 50% goal has been picked because it's a number that improves the current situation and it is uncertain whether reaching greater coverages is doable in the next cycle.

@hellais hellais transferred this issue from ooni/probe-cli Jan 13, 2020
@bassosimone bassosimone changed the title Increase code coverage to >= 50% probe-cli: increase code coverage to >= 50% Aug 31, 2020
@bassosimone bassosimone added this to the Sprint 26 - Neerali milestone Nov 20, 2020
@bassosimone
Copy link
Contributor Author

I started working on this during Sprint 26. Will continue working on this in subsequent Sprints.

@bassosimone bassosimone changed the title probe-cli: increase code coverage to >= 50% cli: increase code coverage to >= 50% Nov 23, 2020
@bassosimone
Copy link
Contributor Author

Postponing to next Sprint.

@bassosimone
Copy link
Contributor Author

This magically happened when merging probe-engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants