General refactoring #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out of historical reasons most classes were defined in the default namespace whereas others where defined in namespace `violetland`. To move forward and reduce chance of name conflicts (class `Configuration` in default namespace) all classes where moved to namespace `violet`. The name `violet` was chosen over `violetland` in order to enable explicit namespacing without too much visual distraction.
Used explicit namespace where appropriate.
ooxi
added a commit
that referenced
this pull request
Jan 14, 2016
General refactoring * Out of historical reasons most classes were defined in the default namespace whereas others where defined in namespace `violetland`. To move forward and reduce chance of name conflicts (class `Configuration` in default namespace) all classes where moved to namespace `violet`. The name `violet` was chosen over `violetland` in order to enable explicit namespacing without too much visual distraction. * All include guards prefixed by `VIOLET_` * Refrain from using namespaces in header files * Clearified copyright and license of `ConfigFile.h` * Removed unnecessary global `GameMode` variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
violetland. To move forward and reduce chance of name conflicts (classConfigurationin default namespace) all classes where moved to namespaceviolet. The namevioletwas chosen overvioletlandin order to enable explicit namespacing without too much visual distraction.VIOLET_ConfigFile.hGameModevariable