Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to commit sha in comment markdown is broken when you first make the comment #51

Closed
bo-chen opened this issue Sep 15, 2011 · 1 comment

Comments

@bo-chen
Copy link
Contributor

bo-chen commented Sep 15, 2011

When a commit sha is included in a comment, its automatically converted to a link to the commit. Right now, the link is broken.
eg.
http://barkeep.sv2/commits//3003df144bbd30e630941fbc6232b3309392cf79

Looks like the repo part is missing, should we assume its always the same repo as the comment is made for?

@cespare
Copy link
Contributor

cespare commented Sep 15, 2011

OK, this is only broken when you initially make the comment. It's because it's rendered in a POST ("/comment") where the helper that does the replacement -- which looks at request.url -- doesn't have the url for the full page.

This isn't super high priority (because in general it will work when viewing the page).

bkad added a commit that referenced this issue Oct 7, 2011
@bkad bkad closed this as completed Oct 7, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants