Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An sms with the content 'OK' gets ignored #7

Closed
Muuo opened this issue Apr 9, 2015 · 6 comments
Closed

An sms with the content 'OK' gets ignored #7

Muuo opened this issue Apr 9, 2015 · 6 comments

Comments

@Muuo
Copy link

Muuo commented Apr 9, 2015

This is probably as a result of these lines in humodem.py

179     if input_line == 'OK':
180         return data

I haven't figured out a workable fix yet. I'm also not very sure what I'd be at risk of breaking.

@fmalina
Copy link
Collaborator

fmalina commented Apr 9, 2015

Confirmed, with additional info:
I have just managed to send a text with content 'OK' from my GSM modem. It arrived fine to my phone.
Although when sending 'OK' from my phone to GSM modem, I received an empty string.
'Ok' works fine both ways, so it's really confusion with the control string.

@oozie
Copy link
Owner

oozie commented Apr 15, 2015

Nice catch and thanks for confirming! Unfortunately, both OK\r\n look the same from the modem's point of view (I was hoping for the return sequence \r\n to be different between control string and content). I'll see how this can be worked around.

@Muuo
Copy link
Author

Muuo commented Apr 15, 2015

Thanks @oozie !

@oozie
Copy link
Owner

oozie commented Apr 15, 2015

Pleasure and thank you for reporting. Let me know if the fix from 8eb2697 worked when you get around to testing it.

fmalina added a commit that referenced this issue Apr 21, 2015
Fix for #7 improper handling of 'OK' content in an SMS
@fmalina fmalina closed this as completed Apr 22, 2015
@Muuo
Copy link
Author

Muuo commented Jul 10, 2015

This comes in a little late... but I wanted to confirm that the fix worked. Thanks!

@oozie
Copy link
Owner

oozie commented Jul 11, 2015

@Muuo great, thanks for circling back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants