Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WebKit Issue #31 #32

Merged
merged 7 commits into from
Aug 16, 2015
Merged

Fix for WebKit Issue #31 #32

merged 7 commits into from
Aug 16, 2015

Conversation

wied03
Copy link
Contributor

@wied03 wied03 commented Aug 16, 2015

Fix for #31

  • Run the browser test in Firefox and Webkit and ensure that works right to prevent this from happening again
  • Handle Webkit/Firefox stack traces properly
  • If we don't match again, fail more gracefully since this is not a 'test should stop' type failure

…r Capybara way (and increase the cushion)

* Don't really need to check JS errors, final result is what matters
@wied03
Copy link
Contributor Author

wied03 commented Aug 16, 2015

@elia - Can you release this as 0.5.0.beta2 ASAP? It might be overkill to even have an implementation of Kernel::caller, but at least now it won't throw if it can't parse.

elia added a commit that referenced this pull request Aug 16, 2015
@elia elia merged commit cb4a1c4 into opal:master Aug 16, 2015
@wied03 wied03 deleted the bugfix/kernel_caller branch August 16, 2015 21:56
@elia
Copy link
Member

elia commented Aug 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants