WIP, making generated code "use strict" compliant

Author: elia

lib/opal/nodes/helpers.rb

@@ -44,7 +44,7 @@ def variable(name)
       end
 
       def valid_ivar_name?(name)
-        not (PROTO_SPECIAL_PROPS =~ name or PROTO_SPECIAL_METHODS =~ name)
+        not (PROTO_SPECIAL_PROPS =~ name or PROTO_SPECIAL_METHODS =~ name or /^length$/ =~ name)
       end
 
       def ivar(name)

lib/opal/nodes/top.rb

@@ -15,6 +15,8 @@ def compile
 
         opening
         in_scope do
+          line '"use strict"'
+
           body_code = stmt(stmts)
           body_code = [body_code] unless body_code.is_a?(Array)
 

opal/corelib/array.rb

@@ -924,17 +924,17 @@ def fill(*args, &block)
       raise TypeError, "length invalid with range" if two
 
       left   = Opal.coerce_to one.begin, Integer, :to_int
-      `left += #@length` if `left < 0`
+      `left += self.length` if `left < 0`
       raise RangeError, "#{one.inspect} out of range" if `left < 0`
 
       right  = Opal.coerce_to one.end, Integer, :to_int
-      `right += #@length` if `right < 0`
+      `right += self.length` if `right < 0`
       `right += 1` unless one.exclude_end?
 
       return self if `right <= left`
     elsif one
       left   = Opal.coerce_to one, Integer, :to_int
-      `left += #@length` if `left < 0`
+      `left += self.length` if `left < 0`
       left   = 0 if `left < 0`
 
       if two
@@ -944,35 +944,35 @@ def fill(*args, &block)
 
         `right += left`
       else
-        right = @length
+        right = `self.length`
       end
     else
       left  = 0
-      right = @length
+      right = `self.length`
     end
 
-    if `left > #@length`
+    if `left > self.length`
       %x{
-        for (i = #@length; i < right; i++) {
+        for (i = self.length; i < right; i++) {
           self[i] = nil;
         }
       }
     end
 
-    if `right > #@length`
-      @length = right
+    if `right > self.length`
+      `self.length = right`
     end
 
     if block
       %x{
-        for (length = #@length; left < right; left++) {
+        for (length = self.length; left < right; left++) {
           value = block(left);
           self[left] = value;
         }
       }
     else
       %x{
-        for (length = #@length; left < right; left++) {
+        for (length = self.length; left < right; left++) {
           self[left] = #{obj};
         }
       }

opal/corelib/runtime.js

@@ -12,6 +12,7 @@
   //
   //   The way the code is digested before going through Yardoc is a secret kept
   //   in the docs repo (https://github.com/opal/docs/tree/master).
+  "use strict"
 
   if (typeof(this.Opal) !== 'undefined') {
     console.warn('Opal already loaded. Loading twice can cause troubles, please fix your setup.');

opal/corelib/string.rb

@@ -253,8 +253,8 @@ def center(width, padstr = ' ')
     return self if `width <= self.length`
 
     %x{
-      var ljustified = #{ljust ((width + @length) / 2).ceil, padstr},
-          rjustified = #{rjust ((width + @length) / 2).floor, padstr};
+      var ljustified = #{ljust ((width + `self.length`) / 2).ceil, padstr},
+          rjustified = #{rjust ((width + `self.length`) / 2).floor, padstr};
 
       return rjustified + ljustified.slice(self.length);
     }