Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute $@ dynamically #2592

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Compute $@ dynamically #2592

merged 1 commit into from
Oct 12, 2023

Conversation

hmdne
Copy link
Member

@hmdne hmdne commented Sep 28, 2023

This should improve performance a little, so that we don't have to reparse the backtrace for exceptions when we don't need it.

@hmdne hmdne force-pushed the hmdne/dynamic-backtrace branch 2 times, most recently from 9c44577 to b4b313e Compare October 2, 2023 02:12
@elia elia self-requested a review October 5, 2023 08:56
elia
elia approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmdne I pushed an additional commit removing the added runtime helper, I think if we do it, we should apply it everywhere

@hmdne @elia
Compute $@ dynamically
0756cfa 
This should improve performance a little, so that we don't have
to reparse the backtrace for exceptions when we don't need it.
@elia elia merged commit 87bba09 into master Oct 12, 2023
20 checks passed
@elia elia deleted the hmdne/dynamic-backtrace branch October 12, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmdne @elia