String Analysis #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errt
commented
Apr 12, 2021
...NG_OPAL/validate/src/test/java/org/opalj/fpcf/fixtures/string_analysis/LocalTestMethods.java
Outdated
Show resolved
Hide resolved
DEVELOPING_OPAL/tools/src/main/scala/org/opalj/support/info/StringAnalysisReflectiveCalls.scala
Outdated
Show resolved
Hide resolved
...alj/tac/fpcf/analyses/string_analysis/interpretation/interprocedural/ArrayLoadPreparer.scala
Outdated
Show resolved
Hide resolved
OPAL/tac/src/main/scala/org/opalj/tac/fpcf/analyses/string_analysis/preprocessing/Path.scala
Outdated
Show resolved
Hide resolved
OPAL/br/src/main/scala/org/opalj/br/fpcf/properties/string_definition/StringTree.scala
Outdated
Show resolved
Hide resolved
...c/main/scala/org/opalj/tac/fpcf/analyses/string_analysis/InterproceduralStringAnalysis.scala
Outdated
Show resolved
Hide resolved
...c/main/scala/org/opalj/tac/fpcf/analyses/string_analysis/InterproceduralStringAnalysis.scala
Outdated
Show resolved
Hide resolved
...scala/org/opalj/tac/fpcf/analyses/string_analysis/interpretation/InterpretationHandler.scala
Outdated
Show resolved
Hide resolved
...ring_analysis/interpretation/interprocedural/VirtualFunctionCallPreparationInterpreter.scala
Outdated
Show resolved
Hide resolved
johannesduesing
pushed a commit
that referenced
this pull request
Feb 1, 2023
Former-commit-id: 614a9d487563eced85c8c307f4e569848382a417
johannesduesing
force-pushed
the
feature/StringAnalysis
branch
from
a126ed6
to
af384a3
Compare
errt
commented
Feb 3, 2023
...main/scala/org/opalj/tac/fpcf/analyses/string_analysis/InterproceduralComputationState.scala
Outdated
Show resolved
Hide resolved
… into feature/StringAnalysis
Fixes unknown char value test
errt
commented
Sep 19, 2024
| */ | ||
| package object string { | ||
|
|
||
| type HighSoundness = Boolean |
There was a problem hiding this comment.
Still not sure what the benefit of having this even as a type alias is. Why not just use boolean (note that, at least in the past, Scala tended to introduce lots of unnecessary boxing when using type aliases of primitive types).
| @@ -43,8 +48,10 @@ object StringConstancyLevel { | |||
| Dynamic | |||
| } else if (level1 == PartiallyConstant || level2 == PartiallyConstant) { | |||
| PartiallyConstant | |||
| } else { | |||
| } else if (level1 == Constant || level2 == Constant) { | |||
There was a problem hiding this comment.
Shouldn't this method be called meet?
| @@ -65,7 +72,9 @@ object StringConstancyLevel { | |||
| level1: StringConstancyLevel, | |||
| level2: StringConstancyLevel | |||
| ): StringConstancyLevel = { | |||
| if (level1 == PartiallyConstant || level2 == PartiallyConstant) { | |||
| if (level1 == Invalid || level2 == Invalid) { | |||
| PartiallyConstant | |||
There was a problem hiding this comment.
Looks wrong. If both are Invalid, shouldn't the result be Invalid as well?
| * Checks whether the given type is supported by the field read analysis, i.e. if it may contain values desirable | ||
| * AND resolvable by the string analysis as a whole. | ||
| */ | ||
| private def isSupportedType(fieldType: FieldType): Boolean = fieldType.isBaseType || fieldType == ObjectType.String |
There was a problem hiding this comment.
I think this can even use eq instead of ==
| /** | ||
| * @author Maximilian Rüsch | ||
| */ | ||
| trait UniversalStringConfig { |
There was a problem hiding this comment.
Maybe rename to sth. like StringAnalysisConfig?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the string analysis (the interprocedural as well as the intraprocedural variant).
Original PR by PatrickN.