Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Twirl instead of scalate #35

Merged
merged 9 commits into from
Jul 13, 2021
Merged

Use Twirl instead of scalate #35

merged 9 commits into from
Jul 13, 2021

Conversation

TorunR
Copy link
Collaborator

@TorunR TorunR commented Jul 8, 2021

  • Refactor Template accordingly
  • Invokes the twirl template using reflection. This is ugly but it
    works.

@TorunR
Use Twirl instead of scalate
7618b5e 
* Refactor Template accordingly
* Invokes the twirl template using reflection. This is ugly but it
  works.
@TorunR TorunR requested a review from errt July 8, 2021 16:51
errt
errt requested changes Jul 9, 2021
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
project/SiteGeneration.scala Show resolved Hide resolved
project/SiteGeneration.scala Outdated Show resolved Hide resolved
src/site/defaultTemplate.scala.html Outdated Show resolved Hide resolved
@TorunR TorunR requested a review from errt July 9, 2021 10:09
@errt
Copy link
Collaborator

errt commented Jul 9, 2021 •
edited
Loading

The code looks good to me now, but did you check the output? The HTML seems severely broken for the table of contents. E.g., now quotation marks are generated around anchor urls, headings are generated as
<a href=/null.html>Text</a><br> instead of <br><b>Text</b><br>
and there is lots of additional whitespace.
The commented out script has also reappeared in the output.

@TorunR
Copy link
Collaborator Author

TorunR commented Jul 9, 2021

I did check only an intermediate Version. I'll have to recheck

errt
errt approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@errt errt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@errt errt self-requested a review July 9, 2021 14:23
errt
errt requested changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@errt errt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, urls of TOC still without quotation marks...

@TorunR TorunR requested a review from errt July 13, 2021 13:02
@TorunR TorunR merged commit 144233e into develop Jul 13, 2021
@errt errt deleted the feature/moveToTwirl branch July 15, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errt errt errt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TorunR @errt