376 move slugbuilder hook

[tombh]

Relates to #376

[mboersma]

Some flake8 errors, apparently.

[coveralls]

Coverage remained the same when pulling 0896b9b on tombh:376-move-slugbuilder-hook into b15d949 on opdemand:master.

[mboersma]

I think I have everything correct--I purged all my cookbooks and uploaded those from @tombh's branch, then provisioned a new controller, then updated its codebase to this PR, reloaded, chef-client, etc. This is all I can get:

$ git push deis master
Counting objects: 17, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (14/14), done.
Writing objects: 100% (17/17), 8.02 KiB | 0 bytes/s, done.
Total 17 (delta 5), reused 0 (delta 0)
Traceback (most recent call last):
  File "/opt/deis/controller/bin/slugbuilder-hook.py", line 12, in <module>
    CONTROLLER_DIR = os.environ['CONTROLLER_DIR']
  File "/opt/deis/controller/venv/lib/python2.7/UserDict.py", line 23, in __getitem__
    raise KeyError(key)
KeyError: 'CONTROLLER_DIR'
To git@deis-controller.local:easier-vineyard.git
 * [new branch]      master -> master
error: failed to push some refs to 'git@deis-controller.local:easier-vineyard.git'

Indeed, my /etc/environment looks like this:

PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games"
SLUG_DIR=/opt/deis/build/slugs

I can't tell why CONTROLLER_DIR isn't getting set.

[tombh]

I've had a quick look and can reproduce this, but can't figure it out either. Most odd. I'll have to have a go again after Christmas now.