refactor(seed-deis-registry): move to .service file #770
Conversation
Moves seed-deis-registry to its own .service file, as it doesn't need to run on all hosts (and shouldn't be specified in user-data).
|
LGTM. |
| @@ -0,0 +1,11 @@ | |||
| [Unit] | |||
| Description=Seed Deis Registry with Docker Images | |||
| Requires=seed-docker-images.service deis-registry.service | |||
There was a problem hiding this comment.
The only instance of seed-docker-images.service is inside contrib/coreos/user-data. I guess that means that contrib/rackspace and contrib/ec2 should be using this user-data file? Not sure if I can point to one in a CloudFormation template, as it's built into the template.
There was a problem hiding this comment.
My work right now is paring down our user-data file -- it really doesn't need much in it. You'll notice that both EC2 and Rackspace are quite happy without it, expect that they need the public IP, private IP, and etcd discovery endpoints.
In short, yes :) We should only have one user-data file across everything. This commit helps me start moving stuff out of there.
There was a problem hiding this comment.
They also need etcd.service and fleet.service running as well, but I agree.
|
LGTM |
refactor(seed-deis-registry): move to .service file
Moves seed-deis-registry to its own .service file, as it doesn't
need to run on all hosts (and shouldn't be specified in user-data).