Scrollable - Improved change detection #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n checking for changes in `updateScrollbars`
added 2 commits
July 4, 2022 09:56
…ion when checking for changes in `updateScrollbars`
…ttps://github.com/open-amdocs/webrix into scrollable-should-update-on-width-or-height-change
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 61 61
Lines 852 852
Branches 29 29
=======================================
Hits 818 818
Misses 33 33
Partials 1 1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.5.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clientWidth&clientHeightshould be taken into consideration when checking for changes inupdateScrollbars.This PR is a result of a bug I've seen in some situations, when the
clientHeightchanged in an editable (multiline) text box, when content is added/removed, and the scrollbar appears when it shouldn't have.