Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project_data.ts with Indigent stats project #29

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

lianilychee
Copy link
Member

Addresses #20

@vercel
Copy link

vercel bot commented Dec 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
website-v2 ✅ Ready (Inspect) Visit Preview Dec 14, 2022 at 8:42PM (UTC)

@lianilychee
Copy link
Member Author

@attali-david this is ready for review now

info in card is based off of https://open-austin.slack.com/archives/C022P5FBMCY/p1670014147061669

@lianilychee lianilychee changed the title (WIP PR) Update project_data.ts with Indigent stats project Update project_data.ts with Indigent stats project Dec 12, 2022
contact: ['Dan Minshew', '@newswim'],
date: '2019-03-14T00:00:00.000Z',
thumb: null,
screenshot: `ballotapi.jpg`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not the right screenshot. One option would be to grab a screenshot from Emily's demo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you either a/ grab screenshot or b/ gimme the link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@lianilychee lianilychee Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newswim where do I put thumbnails? I clicked thru every subdirectory. /public/assets seem like the best bet but I don't see any other thumbs.. Or thumbnails.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we aren't actually using any screenshots right now. At one point @attali-david was going to set up the image hosting on Vercel. I'll see if he still has some bandwidth to do that. If not I could do it some time next week.

Copy link
Member Author

@lianilychee lianilychee Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newswim just file a ticket for it; don't actually do it #scopecreep Let's get ship this and then when the new year hits, we can figure what goes into V2.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newswim I need your approval on review before I can merge

data/project_data.ts Outdated Show resolved Hide resolved
data/project_data.ts Outdated Show resolved Hide resolved
Indigent stats - Changed start date (mysteriously a timestamp).  Updated descr.
@newswim newswim merged commit fac5fbd into main Dec 15, 2022
@newswim newswim deleted the llye/update-projects branch December 15, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants