Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build string to packages in conda environment files #36

Merged
merged 3 commits into from
May 10, 2021

Conversation

bnemanich
Copy link
Member

@bnemanich bnemanich commented May 7, 2021

Checklist before submitting

Description

The pyarrow package doesn't have meta packages with different names for choosing cpu and cuda builds. Instead, it relies on the information in the build string for picking the correct package. Because of this, the conda environment files that we are currently generating always pick the default build type.

This PR adds the build strings to the generated packages listed in the conda environment files, which will allow for the correct version of pyarrow to be selected.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one maintainer must review and approve.
  3. If any maintainer requests changes, they must be addressed.

@codecov-commenter
Copy link

Codecov Report

Merging #36 (701499a) into main (0a67c27) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   95.51%   95.52%   +0.01%     
==========================================
  Files          21       21              
  Lines        1847     1851       +4     
==========================================
+ Hits         1764     1768       +4     
  Misses         83       83              
Flag Coverage Δ
unittests 95.52% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_ce/build_tree.py 92.71% <100.00%> (+0.02%) ⬆️
open_ce/conda_utils.py 98.65% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a67c27...701499a. Read the comment docs.

@bnemanich bnemanich merged commit d129d0a into open-ce:main May 10, 2021
@bnemanich bnemanich deleted the fix_test_feedstock branch May 10, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants