-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use recipe channels for remote deps. #62
Use recipe channels for remote deps. #62
Conversation
@bethune-bryant - There is one more problem in this flow on x86 RH8 with cuda 11.0.
And we don't take the latest one, we pick up all of these and read the dependencies of all the entries. Ideally we should pick up the newest version which is 11.0.221. I'm not sure if we have encountered such case ever because we have been using a single channel so far. Similar prob would arise when we will have exact same version on both the channels like grpcio=1.35.*. |
We actually get the latest package in open-ce-builder/open_ce/conda_utils.py Lines 127 to 136 in b2aaa52
Which is what we use in open-ce-builder/open_ce/build_tree.py Lines 343 to 345 in b2aaa52
But we've been worried that that could cause issues because it is using the timestamp to get the latest, instead of parsing and comparing versions. Have you seen an issue with this? It may be good to see if there is a conda API function for comparing versions. I'll look into that. |
Yes, I see a problem with this. On x86 with cudatoolkit 11.0, we take the output of conda search based on timestamp if there are more entries found. In my case, conda-forge's cudatoolkit 11.0.3 is the output of get_latest_package_info, and that package shows dependencies as follows -
And __glibc package is not found on any of the channels. And hence validate config fails. |
@npanpaliya
This is closer to what conda is actually doing when installing a package. This should fix the issues you were seeing. This could still run into issues if there are dependency conflicts. But doing anymore would require more integration with the conda solver, which is something that we may need to look into in the future if it becomes an issue. |
Thanks a lot @bethune-bryant ! It worked for me. |
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 96.69% 96.70% +0.01%
==========================================
Files 23 23
Lines 1964 1971 +7
==========================================
+ Hits 1899 1906 +7
Misses 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Checklist before submitting
Description
@npanpaliya added an external channel to the xgboost env file and it wasn't being used during remote dependency retrieval.