Replace date-fns by date-and-time-formatter
#443
Conversation
paescuj
changed the title
date-fns by date-and-time-formatter
paescuj
force-pushed
the
replace-date-fns-by-date-and-time-formatter
branch
from
7fd13e6
to
28f51ae
Compare
| @@ -151,7 +151,7 @@ const args = yargs(argsBeforeSep) | |||
| }, | |||
| 'timestamp-format': { | |||
| alias: 't', | |||
| describe: 'Specify the timestamp in moment/date-fns format.', | |||
| describe: 'Specify the timestamp in Unicode LDML format.', | |||
There was a problem hiding this comment.
While this is technically correct, I wonder how many people won't know how to find usage examples for LDML.
For instance, for me, Google returns one result for "unicode ldml" in the first page that is more "straight to the point" IMO:
https://stackoverflow.com/q/39904392/2083599
There was a problem hiding this comment.
Good point! Should we explicitly link https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns in this description?
There was a problem hiding this comment.
Probably, but i'm worried it might not be formatted well by yargs.
Something like #445 (or better) is looking promising now...
| @@ -43,7 +43,7 @@ export type ConcurrentlyOptions = BaseConcurrentlyOptions & { | |||
|
|
|||
| /** | |||
| * Date format used when logging date/time. | |||
| * @see https://date-fns.org/v2.0.1/docs/format | |||
| * @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table | |||
There was a problem hiding this comment.
| * @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table | |
| * @see https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns |
| @@ -61,7 +61,7 @@ export const success = 'all' as SuccessCondition; | |||
|
|
|||
| /** | |||
| * Date format used when logging date/time. | |||
| * @see https://date-fns.org/v2.0.1/docs/format | |||
| * @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table | |||
There was a problem hiding this comment.
| * @see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table | |
| * @see https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns |
| @@ -346,7 +348,7 @@ For more details, visit https://github.com/open-cli-tools/concurrently | |||
| Anything else means all processes should exit successfully. | |||
| - `restartTries`: how many attempts to restart a process that dies will be made. Default: `0`. | |||
| - `restartDelay`: how many milliseconds to wait between process restarts. Default: `0`. | |||
| - `timestampFormat`: a [date-fns format](https://date-fns.org/v2.0.1/docs/format) | |||
| - `timestampFormat`: a [Unicode LDML format](https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table) | |||
There was a problem hiding this comment.
| - `timestampFormat`: a [Unicode LDML format](https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table) | |
| - `timestampFormat`: a [Unicode LDML date format](https://unicode.org/reports/tr35/tr35-dates.html#Date_Format_Patterns) |
|
It would be helpful to either upgrade to Thanks everyone!! |
|
Hey! This is now fixed in v9.0.0. |
Fixes #436
Backwards-compatible because
date-fnsfollows Unicode LDML too (well, more or less https://blog.date-fns.org/v2-unicode-tokens/)