Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix midstream e2e test failure #260

Merged
merged 1 commit into from
Oct 6, 2022
Merged

ci: fix midstream e2e test failure #260

merged 1 commit into from
Oct 6, 2022

Conversation

TomerFi
Copy link
Member

@TomerFi TomerFi commented Oct 5, 2022

@TomerFi
ci: fix midstream e2e test failure
243b378 
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
chenz4027
chenz4027 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@chenz4027 chenz4027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the quick fix

@openshift-ci openshift-ci bot added the lgtm label Oct 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, TomerFi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 934652c into open-cluster-management-io:main Oct 6, 2022
This was referenced Oct 6, 2022
Closed
Closed
TomerFi added a commit to TomerFi/multicloud-operators-subscription that referenced this pull request Nov 22, 2022
@TomerFi @openshift-merge-robot
ci: fix midstream e2e test failure (open-cluster-management-io#260)
93236a0 
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
(cherry picked from commit 934652c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenz4027 chenz4027 chenz4027 approved these changes

@lennysgarage lennysgarage Awaiting requested review from lennysgarage

@rokej rokej Awaiting requested review from rokej

Assignees

@chenz4027 chenz4027

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomerFi @chenz4027 @openshift-merge-robot