🐛 Fix: change singleton agent sa to work sa #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 60.98% 61.03% +0.05%
==========================================
Files 128 128
Lines 13686 13719 +33
==========================================
+ Hits 8347 8374 +27
- Misses 4575 4580 +5
- Partials 764 765 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
qiujian16
force-pushed
the
work-sa
branch
10 times, most recently
from
bd9ac0f
to
7697e8f
Compare
Signed-off-by: Jian Qiu <jqiu@redhat.com>
|
LGTM |
zhujian7
reviewed
Sep 15, 2023
| @@ -7,7 +7,7 @@ metadata: | |||
| roleRef: | |||
| apiGroup: rbac.authorization.k8s.io | |||
| kind: ClusterRole | |||
| name: open-cluster-management:{{ .KlusterletName }}-work:execution | |||
| name: open-cluster-management:{{ .KlusterletName }}-work:aggregate | |||
There was a problem hiding this comment.
since we have the aggregate rule, do we still need this binding?
|
/lgtm |
openshift-merge-robot
merged commit bd4982f
into
open-cluster-management-io:main
13 checks passed
TomerFi
pushed a commit
to TomerFi/OCM
that referenced
this pull request
Sep 27, 2023
Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com>
TomerFi
pushed a commit
to TomerFi/OCM
that referenced
this pull request
Sep 27, 2023
Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #