Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit inference ppl datasets #1315

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Conversation

Quehry
Copy link
Contributor

@Quehry Quehry commented Jul 12, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Commit the inference ppl datasets

Modification

Commit the inference ppl datasets

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@tonysy
Copy link
Collaborator

tonysy commented Jul 14, 2024

Please use pre-commit to fix the lint issue. @Quehry

configs/eval_inference_ppl.py Outdated Show resolved Hide resolved
configs/eval_inference_ppl.py Outdated Show resolved Hide resolved
configs/datasets/inference_ppl/inference_ppl.py Outdated Show resolved Hide resolved
configs/datasets/inference_ppl/README.md Outdated Show resolved Hide resolved
@Quehry Quehry requested a review from acylam July 15, 2024 05:19
@tonysy tonysy changed the base branch from main to dev July 16, 2024 08:20
@acylam
Copy link
Collaborator

acylam commented Jul 17, 2024

@Quehry Please fix the linting issues with pre-commit checks

Copy link
Collaborator

@acylam acylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR!

@acylam acylam added the Dataset Support for new dataset label Jul 22, 2024
@tonysy tonysy self-requested a review July 22, 2024 02:33
@tonysy tonysy changed the base branch from dev to main July 22, 2024 09:56
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonysy tonysy merged commit a244453 into open-compass:main Jul 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dataset Support for new dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants