Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi model viz #509

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

Sanster
Copy link
Contributor

@Sanster Sanster commented Oct 27, 2023

Motivation

Added a new tool script that can visually compare the result of different models in the command line.

image

Modification

  • a new tool script: viz_multi_model.py
  • new dependency package in requirements/runtime.txt:
    • rich: for beautiful formatting in the terminal
    • typer: make write cli tool easier

Use cases

Model configurations and outputs that can be used for testing: example_configs_and_outputs.zip

use case1: show summarizer of different models, the script will check if the dataset of the model is consistent.

python3 tools/viz_multi_model.py \
--cfg-paths ./configs/eval_model1.py \
--work-dirs ./outputs/model1/20231025_153230 \
--cfg-paths ./configs/eval_model2.py \
--work-dirs ./outputs/model2/20231025_110325
image

use case2: show metrics in a summary group by adding --group ceval

python3 tools/viz_multi_model.py \
--cfg-paths ./configs/eval_model1.py \
--work-dirs ./outputs/model1/20231025_153230 \
--cfg-paths ./configs/eval_model2.py \
--work-dirs ./outputs/model2/20231025_110325 \
--group ceval
image

@Leymore Leymore requested a review from yingfhu October 27, 2023 03:53
Copy link
Contributor

@yingfhu yingfhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your great work!!! I tested locally, it worked pretty well, except for some subtle enhancements for some corner cases.

tools/viz_multi_model.py Outdated Show resolved Hide resolved
opencompass/summarizers/multi_model.py Outdated Show resolved Hide resolved
opencompass/summarizers/multi_model.py Outdated Show resolved Hide resolved
opencompass/summarizers/multi_model.py Outdated Show resolved Hide resolved
@Sanster
Copy link
Contributor Author

Sanster commented Oct 30, 2023

Thanks a lot for your great work!!! I tested locally, it worked pretty well, except for some subtle enhancements for some corner cases.

Thank you for your detailed review. I just started using OpenCompass and didn't consider some situations. I have made modifications according to the content of the review and pushed a new commit.

Copy link
Contributor

@yingfhu yingfhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yingfhu yingfhu requested a review from Leymore October 30, 2023 03:14
@Leymore Leymore merged commit e2355a2 into open-compass:main Oct 30, 2023
3 checks passed
liushz pushed a commit to liushz/opencompass that referenced this pull request Nov 27, 2023
* add viz_multi_model.py tool

* Modify the viz_multi_model.py script according to the review

* highlight multiple optimal scores

---------

Co-authored-by: wq.chu <wq.chu@tianrang-inc.com>
Co-authored-by: Leymore <zfz-960727@163.com>
liuyaox pushed a commit to liuyaox/opencompass that referenced this pull request Jun 26, 2024
* add viz_multi_model.py tool

* Modify the viz_multi_model.py script according to the review

* highlight multiple optimal scores

---------

Co-authored-by: wq.chu <wq.chu@tianrang-inc.com>
Co-authored-by: Leymore <zfz-960727@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants