[Feature] Support 360API and FixKRetriever for CSQA dataset #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
yingfhu
reviewed
Nov 21, 2023
yingfhu
reviewed
Nov 21, 2023
opencompass/models/ai360_api.py
Outdated
Comment on lines
78
to
108
| def flush(self): | ||
| """Ensure simultaneous emptying of stdout and stderr when concurrent | ||
| resources are available. | ||
|
|
||
| When employing multiprocessing with standard I/O redirected to files, | ||
| it is crucial to clear internal data for examination or prevent log | ||
| loss in case of system failures." | ||
| """ | ||
| if hasattr(self, 'tokens'): | ||
| sys.stdout.flush() | ||
| sys.stderr.flush() | ||
|
|
||
| def acquire(self): | ||
| """Acquire concurrent resources if exists. | ||
|
|
||
| This behavior will fall back to wait with query_per_second if there are | ||
| no concurrent resources. | ||
| """ | ||
| if hasattr(self, 'tokens'): | ||
| self.tokens.acquire() | ||
| else: | ||
| self.wait() | ||
|
|
||
| def release(self): | ||
| """Release concurrent resources if acquired. | ||
|
|
||
| This behavior will fall back to do nothing if there are no concurrent | ||
| resources. | ||
| """ | ||
| if hasattr(self, 'tokens'): | ||
| self.tokens.release() |
liushz
pushed a commit
to liushz/opencompass
that referenced
this pull request
Nov 27, 2023
* [Feature] Support 360API and FixKRetriever for CSQA dataset * Update API * Update API * [Feature] Support 360API and FixKRetriever for CSQA dataset * Update API * Update API * rm mathbench * fix_lint * Update opencompass/models/bytedance_api.py Co-authored-by: Hubert <42952108+yingfhu@users.noreply.github.com> * update * update * update --------- Co-authored-by: Hubert <42952108+yingfhu@users.noreply.github.com>
liuyaox
pushed a commit
to liuyaox/opencompass
that referenced
this pull request
Jun 26, 2024
…pass#601) * [Feature] Support 360API and FixKRetriever for CSQA dataset * Update API * Update API * [Feature] Support 360API and FixKRetriever for CSQA dataset * Update API * Update API * rm mathbench * fix_lint * Update opencompass/models/bytedance_api.py Co-authored-by: Hubert <42952108+yingfhu@users.noreply.github.com> * update * update * update --------- Co-authored-by: Hubert <42952108+yingfhu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: