Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Panik! #758

Merged
merged 2 commits into from
May 2, 2024
Merged

Don't Panik! #758

merged 2 commits into from
May 2, 2024

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented May 2, 2024

The answer is: 42

Description

Populate error to top, if it's not a semver.org conform version.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🎇 Restructuring
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

The answer is: 42
@hilmarf hilmarf added this to the 2024-Q2 milestone May 2, 2024
@github-actions github-actions bot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label May 2, 2024
@hilmarf hilmarf requested a review from mandelsoft May 2, 2024 11:33
Copy link
Contributor

github-actions bot commented May 2, 2024

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 1
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 4
HIGH RISK LICENSES 9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

Copy link
Contributor

ocmbot bot commented May 2, 2024

Integration Tests for 2d1f934 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented May 2, 2024

Integration Tests for 2d1f934 run with result: Success ✅!

@mandelsoft mandelsoft marked this pull request as ready for review May 2, 2024 11:58
@morri-son morri-son merged commit ebe976e into main May 2, 2024
15 checks passed
@morri-son morri-son deleted the fix/panic branch May 2, 2024 12:49
hilmarf added a commit that referenced this pull request May 2, 2024
## Description

## What type of PR is this? (check all applicable)

- [ ] 🍕 Feature
- [ ] 🎇 Restructuring
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [x] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

## Related Issues

- #758
- #756

## Added tests?

- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help
- [ ] Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration


## Added to documentation?

- [ ] 📜 README.md
- [ ] 🙅 no documentation needed

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
@achimweigel
Copy link

@hilmarf thank you very much :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

Panic when calling GetComponentVersion
4 participants