Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync opencraft-release/palm.1 with Upstream 20230717-1689605830 #555

Conversation

opencraft-requirements-bot

Syncing opencraft-release/palm.1 with Upstream

Note on Conflicts ⚠️

In cases of conflicts you can go ahead and resolve it here on Github if it is simple enough. However if it is a more complicated conflict please follow the steps below:

  1. Check out sync-open-release/palm.master-20230717-1689605830 locally:
  2. Pull latest changes from opencraft-release/palm.1 into that branch, make sure your [REMOTE] is pointing to opencraft-release/palm.1:
git pull [REMOTE] opencraft-release/palm.1
  1. Resolve the conflicts locally, then commit the result. This will create a new merge commit.
  2. Push the new merge commit to sync-open-release/palm.master-20230717-1689605830 to update this PR
  3. Review the PR again and merge when ready!
    Note: Please use the "Create a merge commit" option as it avoids issues when checking diffs with upstream.

@Agrendalath Agrendalath force-pushed the sync-open-release/palm.master-20230717-1689605830 branch from 9141a63 to 42e84e3 Compare July 17, 2023 15:10
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the diff matches the upstream commits
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

Regarding the failing commitlint action - the enhancement: prefix is invalid. It was added while squashing and merging the PR to the upstream platform, so the commitlint action could not catch it there.

@Agrendalath Agrendalath merged commit dff4e8c into opencraft-release/palm.1 Jul 17, 2023
@Agrendalath Agrendalath deleted the sync-open-release/palm.master-20230717-1689605830 branch July 17, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants