Fix issue with wrong poll being highlighted. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirdneh
suggested changes
Mar 13, 2019
poll/poll.py
Outdated
| @@ -508,6 +511,7 @@ def tally_detail(self): | |||
| answer['choice'] = True | |||
| try: | |||
| answer['percent'] = round(answer['count'] / float(total) * 100) | |||
| answer['leader'] = answer['count'] == highest_count | |||
There was a problem hiding this comment.
Shouldn't this be outside the try/except to keep the block explicitly catching the lines where that error might happen?
xirdneh
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
👍
- I tested this:
- Ran this on local devstack.
- I read through the code
[ ] I checked for accessibility issues[ ] Includes documentation[ ] I made sure any change in configuration variables is reflected in the corresponding
client'sconfiguration-securerepository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR changed the order in which results were presented, however, the styling code still assumed that the first entry would have the highest vote count and highlighted the first entry.
This change fixes that an makes a subtle enhancement that will now style all top/leading entries.