Minor issue. 1278 specifies that the beam data length is a char (DIS 6) #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not certain about the DIS7 implementation, but it looks like the DIS6 UaPDU has a slight problem with the Acoustic Beam Data struct. The beam data length field is listed as a 8 bit value in the 1278 spec so I changed it from a short to a char and adjusted the marshalled size function by one as well.
This time the PR has the correct committer email :D