-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rest api and file provider #28
Merged
toddbaert
merged 3 commits into
open-feature:main
from
toddbaert:feat/rest-api-and-file-provider
Jun 10, 2022
Merged
Feat/rest api and file provider #28
toddbaert
merged 3 commits into
open-feature:main
from
toddbaert:feat/rest-api-and-file-provider
Jun 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
force-pushed
the
feat/rest-api-and-file-provider
branch
5 times, most recently
from
June 8, 2022 03:51
88e6d92
to
014188e
Compare
Hey great stuff, Can we talk this one through on a zoom call @toddbaert ? |
toddbaert
force-pushed
the
feat/rest-api-and-file-provider
branch
5 times, most recently
from
June 10, 2022 15:34
a5baf96
to
15ef2b6
Compare
toddbaert
commented
Jun 10, 2022
toddbaert
force-pushed
the
feat/rest-api-and-file-provider
branch
2 times, most recently
from
June 10, 2022 15:42
b334cdc
to
7fa8378
Compare
toddbaert
commented
Jun 10, 2022
toddbaert
commented
Jun 10, 2022
toddbaert
commented
Jun 10, 2022
toddbaert
force-pushed
the
feat/rest-api-and-file-provider
branch
from
June 10, 2022 15:58
7fa8378
to
6c940a9
Compare
toddbaert
commented
Jun 10, 2022
toddbaert
commented
Jun 10, 2022
toddbaert
force-pushed
the
feat/rest-api-and-file-provider
branch
from
June 10, 2022 16:13
6c940a9
to
2b9339c
Compare
toddbaert
commented
Jun 10, 2022
AlexsJones
requested changes
Jun 10, 2022
Co-authored-by: Alex Jones <alex.jones@canonical.com>
AlexsJones
approved these changes
Jun 10, 2022
toddbaert
force-pushed
the
feat/rest-api-and-file-provider
branch
from
June 10, 2022 18:26
d963b04
to
f8a8e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
IEvaluator
interface. This is the "brain" doing flag evaluation. It knows hot to take a string from theISync
'sFetch
method, and convert it to a particular schema, and then perform flag evaluations. The only implementation so far is theJsonEvaluator
, which uses the schema here (included as a submodule)The Chi framework was used since it has no dependencies, and is compatible with native go
net/http
handlers.To test:
git submodule update --init --recursive
go mod download
make build
(which is now includes ofmake generate
). The generated code is .gitignored.Then, you can perform flag evaluations after running
./flagd start --uri ./examples/provider_flags.json
Closes: #23
Closes: #27