Skip to content

Commit

Permalink
fixup: lint and todos
Browse files Browse the repository at this point in the history
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
  • Loading branch information
toddbaert committed Feb 15, 2024
1 parent 8be799d commit bd39f99
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ private FlagParser() {
/**
* Parse {@link String} for feature flags.
*/
public static Map<String, FeatureFlag> parseString(final String configuration, boolean throwIfInvalid) throws IOException {
public static Map<String, FeatureFlag> parseString(final String configuration, boolean throwIfInvalid)
throws IOException {
if (SCHEMA_VALIDATOR != null) {
try (JsonParser parser = MAPPER.createParser(configuration)) {
Set<ValidationMessage> validationMessages = SCHEMA_VALIDATOR.validate(parser.readValueAsTree());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ public void grpcConnectionStatus() throws Throwable {
// accepted data
grpcStreamHandler.onNext(
SyncFlagsResponse.newBuilder()
// .setState(SyncState.SYNC_STATE_ALL)
.build());

assertTimeoutPreemptively(MAX_WAIT_MS, () -> {
Expand All @@ -92,13 +91,11 @@ public void grpcConnectionStatus() throws Throwable {
// ping must be ignored
grpcStreamHandler.onNext(
SyncFlagsResponse.newBuilder()
// .setState(SyncService.SyncState.SYNC_STATE_PING)
.build());

// accepted data
grpcStreamHandler.onNext(
SyncFlagsResponse.newBuilder()
// .setState(SyncService.SyncState.SYNC_STATE_ALL) TODO: this and others
.build());

assertTimeoutPreemptively(MAX_WAIT_MS, () -> {
Expand Down

0 comments on commit bd39f99

Please sign in to comment.