Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OFREP web provider #776

Merged
merged 45 commits into from
Apr 5, 2024
Merged

feat: OFREP web provider #776

merged 45 commits into from
Apr 5, 2024

Conversation

thomaspoignant
Copy link
Member

This is a long-running PR for the OFREP-web provider, the goal is to use this to use this PR to test the implementation of the OpenFeature Remote Evaluation Protocol to understand the limit of the protocol.

Check open-feature/protocol to know more about it.

@thomaspoignant
Update OF packages
76408f0 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
POC remote evaluation
d2d0a3a 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Adding ETag management
2679a2d 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Add polling
b3b7cc7 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant mentioned this pull request Feb 16, 2024
Merged
@thomaspoignant
OFREP web provider
75f7547 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Emit configurationChanged event
23af98e 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
add tests
dc3db76 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Add more tests
180f3d4 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Adding tests
91578a8 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Address review comments
700d814 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Commenting the checks because of STALE evaluation not returning CACHED
166d3ed 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant marked this pull request as ready for review March 29, 2024 20:06
@thomaspoignant thomaspoignant requested a review from a team as a code owner March 29, 2024 20:06
beeme1mr and others added 5 commits March 29, 2024 16:37
@beeme1mr
regenerate package lock
08a6e04 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
Merge branch 'main' into ofrep-web-provider-poc
71f0b25 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
add missing comma
b97f648 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@thomaspoignant
Handle 428 retry-after header
2055c33 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Fix test in ofrep-core
9b93ab2 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
Closed
@thomaspoignant
Merge remote-tracking branch 'origin/main' into ofrep-web-provider-poc
5a4c8f0
@thomaspoignant
Add peer dependency to ofrep-core
6f1666d 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Use retryAfter method from ofrep-core
8036e22 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Add the right version
ad2674c 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant changed the title feat: OFREP web provider POC feat: OFREP web provider Apr 4, 2024
@thomaspoignant
remove coverage folder
71cecda 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant force-pushed the ofrep-web-provider-poc branch 2 times, most recently from 48688f1 to 55262de Compare April 4, 2024 19:44
lukas-reining
lukas-reining approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found one nit, otherwise this looks great!
Really looking forward! :)

libs/providers/ofrep-web/src/lib/ofrep-web-provider.ts Outdated Show resolved Hide resolved
@thomaspoignant
Renaming options type
127f79d 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
fix typo
8b81130 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Use not experimental version
9da3a6d 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant
Merge branch 'main' into ofrep-web-provider-poc
7197251 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@beeme1mr
Copy link
Member

beeme1mr commented Apr 5, 2024

Should we try and release today?

@thomaspoignant
Copy link
Member Author

Should we try and release today?

That would be awesome.
I'll release it now.

@thomaspoignant thomaspoignant merged commit 9626ef4 into main Apr 5, 2024
6 checks passed
@thomaspoignant thomaspoignant deleted the ofrep-web-provider-poc branch April 5, 2024 13:56
This was referenced Apr 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@lukas-reining lukas-reining lukas-reining approved these changes

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomaspoignant @beeme1mr @Kavindu-Dodan @toddbaert @lukas-reining