-
Notifications
You must be signed in to change notification settings - Fork 28
feat: add hook data #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hook data #533
Conversation
Signed-off-by: gruebel <anton.gruebel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the OpenFeature Python SDK by implementing the hook_data
concept. This feature allows developers to attach and manage custom data within the lifecycle of flag evaluations, providing a standardized way for hooks to communicate and share state without breaking existing functionality.
Highlights
- Hook Data Support: Introduces support for
hook_data
within theHookContext
, allowing hooks to store and share arbitrary data throughout the flag evaluation lifecycle, aligning with the OpenFeature specification. - Internal Hook Refactoring: Refactors internal hook execution mechanisms to pass
HookContext
alongsideHook
instances, ensuring properhook_data
propagation and maintaining backward compatibility. - New Hook Data Type: Defines a new
HookData
type as a mutable mapping, providing a flexible structure for storing hook-specific information. - Enhanced Test Coverage: Adds new dedicated tests to validate the correct behavior and isolation of
hook_data
between different hooks.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
+ Coverage 97.81% 97.85% +0.04%
==========================================
Files 38 39 +1
Lines 1786 1822 +36
==========================================
+ Hits 1747 1783 +36
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for hook data, allowing hooks to maintain state across different stages of the evaluation lifecycle. The implementation aligns well with the OpenFeature specification and is accompanied by new and updated tests. The changes are generally solid, but I've identified an opportunity for simplification in openfeature/client.py
to improve code clarity and efficiency by removing a redundant reduce
operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you this looks good to me
Signed-off-by: gruebel <anton.gruebel@gmail.com>
This PR
Related Issues
Fixes #506