Skip to content

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Aug 31, 2025

This PR

  • adds support for hook data while keeping backwards compatibility
  • I used the JS implementation as inspiration

Related Issues

Fixes #506

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel requested review from a team as code owners August 31, 2025 21:01
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gruebel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the OpenFeature Python SDK by implementing the hook_data concept. This feature allows developers to attach and manage custom data within the lifecycle of flag evaluations, providing a standardized way for hooks to communicate and share state without breaking existing functionality.

Highlights

  • Hook Data Support: Introduces support for hook_data within the HookContext, allowing hooks to store and share arbitrary data throughout the flag evaluation lifecycle, aligning with the OpenFeature specification.
  • Internal Hook Refactoring: Refactors internal hook execution mechanisms to pass HookContext alongside Hook instances, ensuring proper hook_data propagation and maintaining backward compatibility.
  • New Hook Data Type: Defines a new HookData type as a mutable mapping, providing a flexible structure for storing hook-specific information.
  • Enhanced Test Coverage: Adds new dedicated tests to validate the correct behavior and isolation of hook_data between different hooks.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

codecov bot commented Aug 31, 2025

Codecov Report

❌ Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.85%. Comparing base (32fdec1) to head (d0f69ad).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
openfeature/client.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   97.81%   97.85%   +0.04%     
==========================================
  Files          38       39       +1     
  Lines        1786     1822      +36     
==========================================
+ Hits         1747     1783      +36     
  Misses         39       39              
Flag Coverage Δ
unittests 97.85% <98.21%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for hook data, allowing hooks to maintain state across different stages of the evaluation lifecycle. The implementation aligns well with the OpenFeature specification and is accompanied by new and updated tests. The changes are generally solid, but I've identified an opportunity for simplification in openfeature/client.py to improve code clarity and efficiency by removing a redundant reduce operation.

Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you this looks good to me

Signed-off-by: gruebel <anton.gruebel@gmail.com>
@gruebel gruebel merged commit 92f5da4 into open-feature:main Sep 4, 2025
16 checks passed
@gruebel gruebel deleted the support-hook-data branch September 4, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hook Data Support
2 participants