Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce codecov volume #67

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 13, 2023

Wow... this has been frustrating...

There's a confluence of issues here:

  • We're uploading codecov in a matrix (this is both unnecessary and can cause issues with too-many-requests), plus it makes the results confusing. I've fixed this by only running it on the first matrix index.
  • The latest hash of the action uses their CLI - which requires a token
  • Renovate doesn't like to (can't?) use hashes for github actions. This might be because version numbers of actions are mutable (the associated commit hash can be changed) so this isn't very helpful.

I've resolved all of the above, but it's quite an annoying situation.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #67 (f3cee2e) into main (c3c1222) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files           6        6           
  Lines          91       91           
=======================================
  Hits           90       90           
  Misses          1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert force-pushed the chore/reduce-codecov-usage branch 3 times, most recently from 2093807 to 1165e6c Compare September 13, 2023 15:46
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@josecolella josecolella merged commit 8b17e0f into main Sep 13, 2023
16 checks passed
@josecolella josecolella deleted the chore/reduce-codecov-usage branch September 13, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants