Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade storybook (v8) #662

Closed
sergei-maertens opened this issue Mar 18, 2024 · 0 comments · Fixed by #663
Closed

Upgrade storybook (v8) #662

sergei-maertens opened this issue Mar 18, 2024 · 0 comments · Fixed by #663
Assignees
@sergei-maertens

Comments

@sergei-maertens
Copy link
Member

Goal was initially to upgrade to the latest v7.x storybook, but in the meantime v8 was released.
@sergei-maertens sergei-maertens self-assigned this Mar 18, 2024
@sergei-maertens sergei-maertens moved this from Todo to In Progress in Development Mar 18, 2024
sergei-maertens added a commit that referenced this issue Mar 18, 2024
@sergei-maertens
⬆️ [#662] Upgrade to latest Storybook 7.x
5e30b2c
@sergei-maertens sergei-maertens mentioned this issue Mar 18, 2024
Merged
sergei-maertens added a commit that referenced this issue Mar 18, 2024
@sergei-maertens
👽 [#662] Remove explicit opt-in to storyStoreV7
4c6462b 
Automigrator detects if it's set, not just its value.
sergei-maertens added a commit that referenced this issue Mar 18, 2024
@sergei-maertens
👽 [#662] Update to new react-router storybook addon
62d2ca1 
* Handle the v1 -> v2 breaking change update
* Handle the project/package rename to be SB8 compatible
sergei-maertens added a commit that referenced this issue Mar 18, 2024
@sergei-maertens
🐛 [#662] Fix infinite loop in story
411349d
sergei-maertens added a commit that referenced this issue Mar 18, 2024
@sergei-maertens
👽 [#662] Fix broken stories
e4b2a32 
* Mocks/spies must now be specified explicitly
* Fixed some minor console warnings/errors
sergei-maertens added a commit that referenced this issue Mar 18, 2024
@sergei-maertens
➖ [#662] Drop @storybook/api@7 dependency
9dd7c26 
Couldn't figure out why it was used.
sergei-maertens added a commit that referenced this issue Mar 18, 2024
@sergei-maertens
👽 [#662] Fixing file upload stories...
df6bbe4 
The testing-library/user-event library upgrade broke the file
uploads.
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Fixing story issues that are revealed by upgrading to SB 8
543a14a
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Replace storybook-addon-themes with storybook-addon-theme-pr…
ffe2ae5 
…ovider
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
⬆️ [#662] Storybook 8.0.1 is released
d3a8ee3
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
🔥 [#662] argTypesRegex is not needed anymore with explicit spies
afa08b7
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
⬆️ [#662] Upgrade to latest Storybook 7.x
40beda4
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Remove explicit opt-in to storyStoreV7
ffd39ce 
Automigrator detects if it's set, not just its value.
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Update to new react-router storybook addon
d6bfc86 
* Handle the v1 -> v2 breaking change update
* Handle the project/package rename to be SB8 compatible
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
🐛 [#662] Fix infinite loop in story
9315e2e
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Fix broken stories
f49d65f 
* Mocks/spies must now be specified explicitly
* Fixed some minor console warnings/errors
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
➖ [#662] Drop @storybook/api@7 dependency
592ada3 
Couldn't figure out why it was used.
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Fixing file upload stories...
b3b6498 
The testing-library/user-event library upgrade broke the file
uploads.
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Fixing story issues that are revealed by upgrading to SB 8
6a29482
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Replace storybook-addon-themes with storybook-addon-theme-pr…
62607aa 
…ovider
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
⬆️ [#662] Storybook 8.0.1 is released
11b0e62
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
🔥 [#662] argTypesRegex is not needed anymore with explicit spies
758b1a9
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
💚 [#662] Reduce test flakiness
356a925
@sergei-maertens sergei-maertens moved this from In Progress to Implemented in Development Mar 19, 2024
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
💚 [#662] Reduce test flakiness
a554be6
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
💚 [#662] Reduce test flakiness
ec7dfdb
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
💚 [#662] Reduce test flakiness
5105154
@sergei-maertens sergei-maertens moved this from Implemented to In Progress in Development Mar 19, 2024
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
⬆️ [#662] Upgrade floating-ui/react
95113f9 
In hopes this fixes test flakiness...
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
💩 [#662] I give up trying to solve this...
bad353d
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
👽 [#662] Add missing (previously implicit) action spies
40a3b88
@sergei-maertens sergei-maertens moved this from In Progress to Implemented in Development Mar 19, 2024
sergei-maertens added a commit that referenced this issue Mar 19, 2024
@sergei-maertens
🔨 [#662] Upgrade to latest Storybook (#663)
92176ca 
* ⬆️ [#662] Upgrade to latest Storybook 7.x

* 👽 [#662] Remove explicit opt-in to storyStoreV7

Automigrator detects if it's set, not just its value.

* ⬆️ Ran the storybook v8 upgrade

* TODO: check dependencies for issues
* TODO: check implicit spies migration

* 👽 [#662] Update to new react-router storybook addon

* Handle the v1 -> v2 breaking change update
* Handle the project/package rename to be SB8 compatible

* 🐛 [#662] Fix infinite loop in story

* 👽 [#662] Fix broken stories

* Mocks/spies must now be specified explicitly
* Fixed some minor console warnings/errors

* ➖ [#662] Drop @storybook/api@7 dependency

Couldn't figure out why it was used.

* 👽 [#662] Fixing file upload stories...

The testing-library/user-event library upgrade broke the file
uploads.

* 👽 [#662] Fixing story issues that are revealed by upgrading to SB 8

* 👽 [#662] Replace storybook-addon-themes with storybook-addon-theme-provider

* ⬆️ [#662] Storybook 8.0.1 is released

* 🔥 [#662] argTypesRegex is not needed anymore with explicit spies

* 💚 [#662] Reduce test flakiness

* ⬆️ [#662] Upgrade floating-ui/react

In hopes this fixes test flakiness...

* 💩 [#662] I give up trying to solve this...

* 👽 [#662] Add missing (previously implicit) action spies
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to latest Storybook open-formulieren/open-forms-sdk
1 participant
@sergei-maertens