Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: Hopefully make keyboard/mouse handling more consistent #2807

Merged
merged 7 commits into from
Jul 8, 2023

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Jul 6, 2023

The current event-based approach is very difficult to get right, and it depends on no events ever being missed. This changes the keyboard/mouse handling code to a polling-based approach.

Other fixes:

  • an issue where modifier keys were not able to be successfully bound (like Left Shift to X)
  • improves cursor hiding (except when you use the start menu, this seems like an SDL issue, see comment)
  • Better discarding of kb/mouse inputs when imgui intercepts input
  • properly swap bindings when an already set key is assigned, even if it crosses the distinction of an analog vs normal button

Fixes #2800

@water111 water111 merged commit 6faa753 into open-goal:master Jul 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[keyboard controls] Analog sticks can get stuck
2 participants