Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: 556 new base image to build arm64 cpu_percent docker container #557

Closed
wants to merge 2 commits into from
Closed

bug: 556 new base image to build arm64 cpu_percent docker container #557

wants to merge 2 commits into from

Conversation

t-fine
Copy link
Collaborator

@t-fine t-fine commented Oct 11, 2022

No description provided.

@t-fine
fix: aarch64 alpine image deprecated
38d1430 
Signed-off-by: Troy Fine <Troy.Fine@ibm.com>
@t-fine
bug: 556 new base image to build arm64 cpu_percent docker container
f7f8315 
Signed-off-by: Troy Fine <Troy.Fine@ibm.com>
@t-fine t-fine linked an issue Oct 11, 2022 that may be closed by this pull request
cpu_percent: aarch64/alpine docker container deprecated #556
Closed
johnwalicki
johnwalicki approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@johnwalicki johnwalicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we are migrating to the ubi9 base image. Approved

@johnwalicki
Copy link
Member

I found an easier way to fix this issue. See #560 and #561

While I like using ubi9 images, I also like how small the alpine images are. Using the technique describe in #560, I was able to build the arm/arm64/amd64 cpu_percent containers successfully using alpine:latest

These alpine container images are tiny compared to the ubi9 implementations.

localhost/openhorizon/ibm.cpu_arm64         1.2.6      a51123e8c8c5  2 minutes ago  10.4 MB
localhost/openhorizon/ibm.cpu_arm           1.2.6      1cd9e27e4dc8  2 minutes ago  7.74 MB
localhost/openhorizon/ibm.cpu_amd64         1.2.6      fb5f7f547ddc  2 minutes ago  10.7 MB

@johnwalicki
Copy link
Member

I suggest we close this PR and open a new PR using the technique described in #560

@johnwalicki
Copy link
Member

If we fix this issue, the "pr-test / build" GHA will finally succeed.

@t-fine
Copy link
Collaborator Author

t-fine commented Oct 24, 2022

Addressed with different PR.

@t-fine t-fine closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnwalicki johnwalicki johnwalicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cpu_percent: aarch64/alpine docker container deprecated
2 participants
@t-fine @johnwalicki