New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #564 : Add a common helloMMS Converge Dockerfile for all ARCH #574

Merged

johnwalicki merged 1 commit into open-horizon:master from dipesh-rawat:Issue564-OneDockerfile

Jan 22, 2023

Contributor

dipesh-rawat commented Jan 22, 2023

This PR fixes #564

The following changes were made in this PR:

Delete the multiple Dockerfile.arch files
Add a common Dockerfile that will be used for building all arch containers
Modify the Makefile to build using docker build --platform linux/$(ARCH)


          Issue open-horizon#564 : Add a common helloMMS Converge Dockerfile fo…

6237edc

…r all ARCH

Signed-off-by: Dipesh Rawat <Dipesh.rawat@ibm.com>

dipesh-rawat mentioned this pull request

Feature Request: helloMMS Converge on one Dockerfile #564

Closed

johnwalicki marked this pull request as ready for review

January 22, 2023 18:20

johnwalicki approved these changes

View reviewed changes

Member

johnwalicki left a comment

LGTM

johnwalicki merged commit 5b21fb8 into open-horizon:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet