Issue33 bug in valve #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo: - fix implementation of idealheater to use correct input temperature - testing
…dium, also updated the extended classes Partial_EmbeddedPipe and Partial_emission
- changed implementation heatedpipe: we do not extend Annex60.Fluid.Interfaces.TwoPortHeatMassExchanger because this model enforces the use of a time constant 'tau' instead of being able to use the mixing volume volume 'V'. Implementation is however based on this model. - heat production components have been adapted to be compatible with this new pipe - the idealheater implementation has been simplified to not use a heatsource
… because of bad borefield model
due to differences with the relevant annex60 baseclasses a different partial was made for pumps: PumpTwoPort.mo . This includes the option to set a fixed mass flow rate, which is not needed for other twoports. This is why it has been moved to a separate partial.
…tend each other and be compatible with annex60 baseclasses
…enceResults/Dymola/ and change name from Annex60 to IDEAS. Conflicts: IDEAS/Thermal/Components/Interfaces/Partials/TwoPort.mo
…ing removed correctly this move has been done in one commit. Due to this large commit it may also contain some real code changes in TwoPort files and Pump files. Gitignore has been extended to exclude .DS_Store files (Mac). Most files have been renamed, but some have been removed as well. This work has mainly been done by Damien Picard.
…ed during the previous commit because they were then not recognised as a 'rename'.
set dependencies of these models from Annex60 models to ideas models
needed correct version number
Pull request of open-ideas/IDEAS/Annex60 to rubenbaetens/IDEAS/master
…an 5e-4. One model had a larger error but this is caused by the changed implementation of a temperature sensor around zero flow
…e test in the pump example package. Added reference result.
Updated PartialHydraulicSystem and Meteo on A60
…default 'prescribedheatflow' parameter = true. This parameter was not propagated to the top. This caused issues when coupling a fixed temperature boundary condition for zero flow. For pumps this parameter is now correctly overridden and set to true since pumps use a prescribedheatflow.
…s to avoid cluttered view
…/open-ideas/IDEAS into issue32_NonLinearHydraulicSystem
…een port_a1 and port_a2. Add examples or update them. Add unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #36. Sorry for the outdated issue number...