Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue66 #67

Closed
wants to merge 5 commits into from
Closed

Issue66 #67

wants to merge 5 commits into from

Conversation

saroele
Copy link
Contributor

@saroele saroele commented Jun 13, 2014

It's not the intention to merge this pull request, just to pass on the model illustrating the issue:
The boundary does not have the wanted temperature.

@Mathadon
Copy link
Member

If I plot fanSup.vol.T the temperature is correct.

Note that fanSup.T is the value of the parameter that can be used to set the boundary temperature but this is not used in this case since you use the input. Is this what caused confusion?

@saroele
Copy link
Contributor Author

saroele commented Jun 15, 2014

No, the confusion/error is the temperature of the boundary. It does not
seem to follow the input?

On Fri, Jun 13, 2014 at 7:34 PM, Filip notifications@github.com wrote:

If I plot fanSup.vol.T the temperature is correct.

Note that fanSup.T is the value of the parameter that can be used to set
the boundary temperature but this is not used in this case since you use
the input. Is this what caused confusion?


Reply to this email directly or view it on GitHub
#67 (comment).

@Mathadon
Copy link
Member

In my previous post the second fanSup.T should have been airAmb.T. Note that the signal has the label 'T' but the actual signal name is T_in. I think this explains the issue?

@Mathadon
Copy link
Member

@saroele can this be closed?

@saroele
Copy link
Contributor Author

saroele commented Jun 24, 2014

not yet, let me check again (maybe friday)

On Tue, Jun 24, 2014 at 2:50 PM, Filip notifications@github.com wrote:

@saroele https://github.com/saroele can this be closed?


Reply to this email directly or view it on GitHub
#67 (comment).

@rubenbaetens
Copy link
Member

So, Jun 24 is long time ago: Can we close this one @saroele ? ;)

@rubenbaetens
Copy link
Member

Shall we try to get rid of pull requests "which shouldn't be merged as it's to show something," that's the purpose of branches, no ? And it's enormously confusing.

@Mathadon
Copy link
Member

Yup:)

@Mathadon Mathadon closed this Oct 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants