Delete exceeding versions when adding a new alias #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.x #1352 +/- ##
=========================================
+ Coverage 77.85% 78.6% +0.76%
=========================================
Files 300 300
Lines 55797 55857 +60
Branches 6480 6485 +5
=========================================
+ Hits 43435 43901 +466
+ Misses 12014 11950 -64
+ Partials 348 6 -342
Continue to review full report at Codecov.
|
AymericDu
force-pushed
the
delete-exceeding-versions
branch
from
dd3cd71
to
4f5b562
Compare
fvennetier
reviewed
Feb 2, 2018
| self.api.object_create(self.account, self.container, | ||
| obj_name="versioned", data="content3") | ||
| new_oldest_version = check_num_objects_and_get_oldest_version(3) | ||
| self.assertNotEqual(oldest_version, new_oldest_version) |
There was a problem hiding this comment.
I would use self.assertLess(oldest_version, new_oldest_version).
| deleted_beans = NULL; | ||
| err = _real_delete_and_save_deleted_beans(sq3, beans, alias, | ||
| header, _bean_list_cb, &deleted_beans); | ||
| cb(u0, deleted_beans); |
There was a problem hiding this comment.
We can pass cb directly to _real_delete_and_save_deleted_beans, don't we?
There was a problem hiding this comment.
cb loads a bean list into a list. So _real_delete_and_save_deleted_beans creates this bean list.
AymericDu
force-pushed
the
delete-exceeding-versions
branch
from
4f5b562
to
b586e75
Compare
AymericDu
force-pushed
the
delete-exceeding-versions
branch
2 times, most recently
from
428e293
to
58bf77e
Compare
AymericDu
force-pushed
the
delete-exceeding-versions
branch
from
58bf77e
to
f336907
Compare
fvennetier
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1163