ui: facet filter and tags-container overflow bug fixes #11119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters will be shown in the left panel. Fixed the overflow issue of tags-container component for longer tag name
aniketkatkar97
requested review from
harshach,
shahsank3t and
chirag-madlani
as code owners
github-actions
bot
added
the
safe to test
|
@aniketkatkar97 we need to show the glossary name and shortened middle parts of the glossary and show the leaf node. It's important to show the leaf node here. Just showing the glossary names is not recognizable for the user cc @chirag-madlani |
Jest test CoverageUI tests summary
|
Passing run #20449 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
Improved Tags component and use antd tag to show tags
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
|
[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!
|
chirag-madlani
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes some issues from #10543
I worked on:
Changed facet filter buckets render length. Only the top 10 most used filters will be shown in the left panel.
Fixed the overflow issue of the tags-container component for a longer tag name
Screen.Recording.2023-04-19.at.6.26.00.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>