Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CYPRESS: fix user cypress failure #16728

Merged
merged 2 commits into from
Jun 20, 2024
Merged

CYPRESS: fix user cypress failure #16728

merged 2 commits into from
Jun 20, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Jun 20, 2024 •
edited
Loading

Describe your changes:

Issue :

  • Not able to find edit description button due to userProfilePanel was closed.
  • collapsible panel was already open and we have closed it causing the issue

Resolved :

  • Remove the unwanted code to open the collapsible panel as it was already open.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added UI UI specific issues e2e:Settings labels Jun 20, 2024
@Ashish8689 Ashish8689 self-assigned this Jun 20, 2024
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs and removed e2e:Settings labels Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.19% (35228/54037) 42.03% (13943/33177) 43.95% (4322/9835)

chirag-madlani
chirag-madlani previously approved these changes Jun 20, 2024
View reviewed changes
@Ashish8689 Ashish8689 enabled auto-merge (squash) June 20, 2024 07:14
@cypress Cypress
Copy link

cypress bot commented Jun 20, 2024 •
edited
Loading

Passing run #34459 ↗︎

0 248 67 0 Flakiness 0

Details:

fix playwright test for user spec
Project: openmetadata Commit: 217109b4aa
Status: Passed Duration: 57:22 💡
Started: Jun 20, 2024 9:15 AM Ended: Jun 20, 2024 10:12 AM

Review all test suite changes for PR #16728 ↗︎

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit cd5d8df into main Jun 20, 2024
16 checks passed
@Ashish8689 Ashish8689 deleted the user-cypress-fix-aut branch June 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Assignees

@Ashish8689 Ashish8689

Labels
e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @chirag-madlani @ShaileshParmar11